chrome/installer/mac/app/Info.plist - Issue 2203583002: Added unpacking step

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/Info.plist

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolved comments, made many minor changes, ready for review! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/mac/app/BUILD.gn ('K') | « chrome/installer/mac/app/Downloader.m ('k') | chrome/installer/mac/app/InstallerWindowController.m » ('j') | chrome/installer/mac/app/InstallerWindowController.m » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>

6 <string>en</string>	6 <string>en</string>

7 <key>CFBundleExecutable</key>	7 <key>CFBundleExecutable</key>

8 <string>$(EXECUTABLE_NAME)</string>	8 <string>mac_installer_app</string>
	Sidney San Martín 2016/08/19 22:06:04 I'd probably hold off on changing this until you/I I'd probably hold off on changing this until you/Ivan can fix them all, instead of just hard-coding this one. Anna Zeng 2016/08/23 03:13:43 Done. Show quoted text On 2016/08/19 22:06:04, Sidney San Martín wrote: > I'd probably hold off on changing this until you/Ivan can fix them all, instead > of just hard-coding this one. Done.
9 <key>CFBundleIconFile</key>	9 <key>CFBundleIconFile</key>

10 <string></string>	10 <string></string>

11 <key>CFBundleIdentifier</key>	11 <key>CFBundleIdentifier</key>

12 <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>	12 <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

13 <key>CFBundleInfoDictionaryVersion</key>	13 <key>CFBundleInfoDictionaryVersion</key>

14 <string>6.0</string>	14 <string>6.0</string>

15 <key>CFBundleName</key>	15 <key>CFBundleName</key>

16 <string>$(PRODUCT_NAME)</string>	16 <string>$(PRODUCT_NAME)</string>

17 <key>CFBundlePackageType</key>	17 <key>CFBundlePackageType</key>

18 <string>APPL</string>	18 <string>APPL</string>

(...skipping 26 matching lines...) Expand all Loading...
45 <dict>	45 <dict>

46 <key>NSIncludesSubdomains</key>	46 <key>NSIncludesSubdomains</key>

47 <true/>	47 <true/>

48 <key>NSTemporaryExceptionAllowsInsecureHTTPLoads</key>	48 <key>NSTemporaryExceptionAllowsInsecureHTTPLoads</key>

49 <true/>	49 <true/>

50 </dict>	50 </dict>

51 </dict>	51 </dict>

52 </dict>	52 </dict>

53 </dict>	53 </dict>

54 </plist>	54 </plist>

OLD	NEW