chrome/installer/mac/app/InstallerWindowController.m - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/InstallerWindowController.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolved comments, made many minor changes, ready for review! Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/InstallerWindowController.m

diff --git a/chrome/installer/mac/app/InstallerWindowController.m b/chrome/installer/mac/app/InstallerWindowController.m

index a69a562a9041486c336b456cce0d6987c530a7df..6c7c6dd3c0264d0bd8353ae5103259fc7fcbab3f 100644

--- a/chrome/installer/mac/app/InstallerWindowController.m

+++ b/chrome/installer/mac/app/InstallerWindowController.m

@@ -111,7 +111,14 @@

}

- (void)updateDownloadProgress:(double)progressPercent {

- progressBar_.doubleValue = progressPercent;

+ if (progressPercent > 0.0) {

+ progressBar_.doubleValue = progressPercent;

+ } else {

+ progressBar_.doubleValue = 0.0;

+ progressBar_.indeterminate = YES;

+ progressBar_.usesThreadedAnimation = YES;

Sidney San Martín 2016/08/19 22:06:04 Looks like this is on by default (on my machine, a

Anna Zeng 2016/08/23 03:13:43 Done.

+ [progressBar_ startAnimation:nil];

+ }

}

@end