Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2205943003: Don't mangle private names. (Closed)

Created:
4 years, 4 months ago by ahe
Modified:
4 years, 4 months ago
Reviewers:
kasperl, kustermann
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@master
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -83 lines) Patch
M lib/kernel.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/kernel/regression/issue_000081.dart.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M test/kernel/regression/mixin_library.dart.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M test/kernel/regression/parser_error.dart.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/static.dart.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M test/kernel/regression/super.dart.txt View 13 chunks +36 lines, -36 lines 0 comments Download
M test/kernel/regression/super_mixin.dart.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M test/kernel/regression/super_operator.dart.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/type_with_parse_error.dart.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M test/kernel/regression/unresolved.dart.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/unresolved_constructor.dart.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/kernel/regression/unresolved_for_in.dart.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M test/kernel/regression/unresolved_recovery.dart.txt View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
This addresses some issues from CL 2116793002: 1. Name mangling isn't necessary, a private name ...
4 years, 4 months ago (2016-08-03 09:35:25 UTC) #2
kustermann
Thank you, LGTM!
4 years, 4 months ago (2016-08-03 10:03:49 UTC) #3
ahe
4 years, 4 months ago (2016-08-03 10:18:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95d3cea885aca38a274917322e553639d2b2d332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698