Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2203143002: GN: add tests to DM (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add tests to DM depends on https://codereview.chromium.org/2202203003 and https://codereview.chromium.org/2208433002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203143002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN-Trybot Committed: https://skia.googlesource.com/skia/+/2f3416d2befb9480b7faf461530fd9044f77e6cd

Patch Set 1 #

Patch Set 2 : compiles, links, sort of runs #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : notes #

Total comments: 1

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : needs jsoncpp #

Patch Set 9 : Headers use json -> public_deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 6 chunks +40 lines, -3 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 19:12:43 UTC) #6
jcgregorio
https://codereview.chromium.org/2203143002/diff/80001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2203143002/diff/80001/BUILD.gn#newcode426 BUILD.gn:426: tests_sources = exec_script("gyp/find.py", Are we going to have the ...
4 years, 4 months ago (2016-08-02 19:58:04 UTC) #8
jcgregorio
LGTM As per offline discussion, we run always run "gn gen" on the bots, so ...
4 years, 4 months ago (2016-08-02 20:25:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203143002/120001
4 years, 4 months ago (2016-08-02 21:33:21 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN-Trybot/builds/0)
4 years, 4 months ago (2016-08-02 21:37:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203143002/160001
4 years, 4 months ago (2016-08-02 22:39:25 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 23:02:09 UTC) #26
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/2f3416d2befb9480b7faf461530fd9044f77e6cd

Powered by Google App Engine
This is Rietveld 408576698