Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2208433002: Delete SkARGBImageEncoder. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete SkARGBImageEncoder. It appears to be unused now except by its unit test, also deleted. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208433002 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/091cb8d72db342b99b573b3598880297b49f40e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -185 lines) Patch
M gyp/images.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageEncoder.h View 1 chunk +0 lines, -5 lines 0 comments Download
D src/images/SkARGBImageEncoder.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
D tests/ARGBImageEncoderTest.cpp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 18:51:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208433002/1
4 years, 4 months ago (2016-08-02 18:51:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12035)
4 years, 4 months ago (2016-08-02 18:52:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208433002/1
4 years, 4 months ago (2016-08-02 19:56:38 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:57:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/091cb8d72db342b99b573b3598880297b49f40e1

Powered by Google App Engine
This is Rietveld 408576698