Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2202203003: not much point to SK_SUPPORT_PDF (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

not much point to SK_SUPPORT_PDF It only controls a few minor things in testing tools, which can always assume PDF support is present. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202203003 Committed: https://skia.googlesource.com/skia/+/757a15fa2e5b8ad46e422ad7e4c10bb5fcb8cae0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M gyp/pdf.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/CanvasTest.cpp View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 19:05:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202203003/1
4 years, 4 months ago (2016-08-02 19:05:21 UTC) #5
hal.canary
lgtm
4 years, 4 months ago (2016-08-02 19:07:02 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:20:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/757a15fa2e5b8ad46e422ad7e4c10bb5fcb8cae0

Powered by Google App Engine
This is Rietveld 408576698