third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js - Issue 2203073004: [DevTools] Add awaitPromise flag to Runtime.runScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

Issue 2203073004: [DevTools] Add awaitPromise flag to Runtime.runScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-call-function-on-async

Patch Set: fixed executionContextId=0 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

index a1197919de872d9e06890a8345f7331396bc0a09..29118ce02c88334341e0a7de9f54a85dc7c88c86 100644

--- a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

@@ -270,7 +270,7 @@ WebInspector.ScriptSnippetModel.prototype = {

_runScript: function(scriptId, executionContext, sourceURL)

{

var target = executionContext.target();

- target.runtimeModel.runScript(scriptId, executionContext.id, "console", false, true, runCallback.bind(this, target));

+ target.runtimeModel.runScript(scriptId, executionContext.id, "console", /* doNotPauseOnExceptionsAndMuteConsole */ false, /* includeCommandLineAPI */ true, /* returnByValue */ false, /* generatePreview */ true, /* awaitPromise */ undefined, runCallback.bind(this, target));

/**

* @param {!WebInspector.Target} target