Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2203073004: [DevTools] Add awaitPromise flag to Runtime.runScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make-call-function-on-async
Patch Set: fixed executionContextId=0 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
index b5afa656b0624547667b591b87942ddd614dbe34..75a28f9184941834c78f185cada2c136ddfd15a6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -229,18 +229,22 @@ WebInspector.RuntimeModel.prototype = {
* @param {string=} objectGroup
* @param {boolean=} doNotPauseOnExceptionsAndMuteConsole
* @param {boolean=} includeCommandLineAPI
+ * @param {boolean=} returnByValue
+ * @param {boolean=} generatePreview
+ * @param {boolean=} awaitPromise
* @param {function(?RuntimeAgent.RemoteObject, ?RuntimeAgent.ExceptionDetails=)=} callback
*/
- runScript: function(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, callback)
+ runScript: function(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, callback)
{
- this._agent.runScript(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, innerCallback);
+ this._agent.runScript(scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, includeCommandLineAPI, returnByValue, generatePreview, awaitPromise, innerCallback);
/**
* @param {?Protocol.Error} error
* @param {?RuntimeAgent.RemoteObject} result
+ * @param {boolean=} wasThrown
* @param {?RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function innerCallback(error, result, exceptionDetails)
+ function innerCallback(error, result, wasThrown, exceptionDetails)
{
if (error) {
console.error(error);

Powered by Google App Engine
This is Rietveld 408576698