Open downloads app when clicking on the downlaod notification of an unresolved type

Open downloads app when clicking on the downlaod notification of an unresolved type

If a download cannot be resolved to any app, nothing happens when
clicking the notification.
This doesn't match the behavior of the snackbar "open" button
This CL changes the behavior to open the downloads app

BUG=633717
Committed: https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154
Cr-Commit-Position: refs/heads/master@{#409632}

[qinmin, 2016-08-02 21:32:59]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-08-02 21:33:00]

PTAL

[Ted C, 2016-08-02 21:47:21]

Let me know if you think we should go down my paranoid route or not.

https://codereview.chromium.org/2202423003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2202423003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:548:
Intent launchIntent = canResolve
While this is an improvement, I believe the safest thing to do would be to
always launch a bouncer intent handler in chrome and check the resolve state
right before you launch here.

With this change, you can start download handled by foo app, then by the time
the download has finished you can have uninstalled foo app and it will no longer
work.

[qinmin, 2016-08-03 20:33:09]

https://codereview.chromium.org/2202423003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2202423003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:548:
Intent launchIntent = canResolve
On 2016/08/02 21:47:21, Ted C wrote:
> While this is an improvement, I believe the safest thing to do would be to
> always launch a bouncer intent handler in chrome and check the resolve state
> right before you launch here.
> 
> With this change, you can start download handled by foo app, then by the time
> the download has finished you can have uninstalled foo app and it will no
longer
> work.


Changed the implementation to send a broadcast intent to
DownloadBroadcastReceiver. And when that intent is received, follow the same
code path as we handle the click of a DownloadManager notification

[Ted C, 2016-08-03 20:50:37]

lgtm

[qinmin, 2016-08-03 21:04:58]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:05:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:48:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 21:51:53]

Description was changed from

==========
Open downloads app when clicking on the downlaod notification of an unresolved
type

If a download cannot be resolved to any app, nothing happens when
clicking the notification.
This doesn't match the behavior of the snackbar "open" button
This CL changes the behavior to open the downloads app

BUG=633717
==========

to

==========
Open downloads app when clicking on the downlaod notification of an unresolved
type

If a download cannot be resolved to any app, nothing happens when
clicking the notification.
This doesn't match the behavior of the snackbar "open" button
This CL changes the behavior to open the downloads app

BUG=633717

Committed: https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154
Cr-Commit-Position: refs/heads/master@{#409632}
==========

[commit-bot: I haz the power, 2016-08-03 21:51:54]

Patchset 2 (id:??) landed as
https://crrev.com/d58f91f1a8237e6a8fa53837785edc2e178e9154
Cr-Commit-Position: refs/heads/master@{#409632}