chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java - Issue 2202423003: Open downloads app when clicking on the downlaod notification of an unresolved type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Issue 2202423003: Open downloads app when clicking on the downlaod notification of an unresolved type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reusing the DownloadManager codepath Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

index 3a62b26ea7c28811caf1dc705c7fc67f32b65f60..b38a2d08fdd648558e8690d9baf24e4f0559443e 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

@@ -237,7 +237,7 @@ public class DownloadNotificationServiceTest extends

sharedPrefs, DownloadNotificationService.PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(3, entries.size());

- service.notifyDownloadSuccessful(guid1, "success", null);

+ service.notifyDownloadSuccessful(guid1, "success", 100L);

entries = DownloadManagerService.getStoredDownloadInfo(

sharedPrefs, DownloadNotificationService.PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(2, entries.size());

@@ -262,7 +262,7 @@ public class DownloadNotificationServiceTest extends

startNotificationService();

DownloadNotificationService service = bindNotificationService();

String guid = UUID.randomUUID().toString();

- service.notifyDownloadSuccessful(guid, "test", null);

+ service.notifyDownloadSuccessful(guid, "test", 100L);

assertEquals(1, getService().getNotificationIds().size());

}