Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2202423003: Open downloads app when clicking on the downlaod notification of an unresolved type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reusing the DownloadManager codepath Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
index 4d37e4d861b583e9f496474008ee8cb670503ade..5d31a2f3ea8b09f85a39e9973e5c0b237f940ddb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
@@ -50,7 +50,6 @@ public class SystemDownloadNotifier implements DownloadNotifier {
// Pending download notifications to be posted.
public final int type;
public final DownloadInfo downloadInfo;
- public Intent intent;
public long startTime;
public boolean isAutoResumable;
public boolean canDownloadWhileMetered;
@@ -179,10 +178,9 @@ public class SystemDownloadNotifier implements DownloadNotifier {
@Override
public void notifyDownloadSuccessful(DownloadInfo downloadInfo, long systemDownloadId,
- boolean canResolve, Intent intent) {
+ boolean canResolve) {
PendingNotificationInfo info =
new PendingNotificationInfo(DOWNLOAD_NOTIFICATION_TYPE_SUCCESS, downloadInfo);
- info.intent = intent;
info.canResolve = canResolve;
info.systemDownloadId = systemDownloadId;
updateDownloadNotification(info);
@@ -283,7 +281,7 @@ public class SystemDownloadNotifier implements DownloadNotifier {
case DOWNLOAD_NOTIFICATION_TYPE_SUCCESS:
final int notificationId = mBoundService.notifyDownloadSuccessful(
info.getDownloadGuid(), info.getFileName(),
- notificationInfo.intent);
+ notificationInfo.systemDownloadId);
onSuccessNotificationShown(notificationInfo, notificationId);
stopServiceIfNeeded();
break;

Powered by Google App Engine
This is Rietveld 408576698