swarming: wholesale switch remaining tests to run on Swarming.

tools/mb/mb.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """MB - the Meta-Build wrapper around GYP and GN
 
 MB is a wrapper script for GYP and GN that can be used to generate build files
 for sets of canned configurations and analyze them.
 """
@@ skipping 1039 matching lines @@
       extra_files = [
           '../../testing/test_env.py'
       ]
       gtest_filter = gn_isolate_map[target]['gtest_filter']
       cmdline = [
           '../../testing/test_env.py',
           './browser_tests' + executable_suffix,
           '--test-launcher-bot-mode',
           '--enable-gpu',
           '--test-launcher-jobs=1',
-          '--gtest_filter=%s' % gtest_filter,
       ]
+      if gtest_filter:
+        cmdline.extend(('--gtest_filter=%s' % gtest_filter))

[Dirk Pranke, 2016/08/03 22:33:44]

ick. I'm surprised this didn't cause more problems.

[M-A Ruel, 2016/08/03 22:37:58]

This was broken, fixed in patchset 4.

     elif test_type == 'script':
       extra_files = [
           '../../testing/test_env.py'
       ]
       cmdline = [
           '../../testing/test_env.py',
           '../../' + self.ToSrcRelPath(gn_isolate_map[target]['script'])
       ]
     elif test_type in ('raw'):
       extra_files = []
@@ skipping 430 matching lines @@
   # Then check to see if the arg contains any metacharacters other than
   # double quotes; if it does, quote everything (including the double
   # quotes) for safety.
   if any(a in UNSAFE_FOR_CMD for a in arg):
     arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg)
   return arg
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))