Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220233011: Implement drawDRRect for GPU (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
jvanverth1
Visibility:
Public.

Description

Implement drawDRRect for GPU BUG=skia:2259 Committed: http://code.google.com/p/skia/source/detail?r=14118

Patch Set 1 #

Patch Set 2 : more things #

Patch Set 3 : working? #

Patch Set 4 : Add test to ignored tests #

Patch Set 5 : update #

Total comments: 2

Patch Set 6 : Address comment #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -59 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +13 lines, -3 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +30 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 5 18 chunks +89 lines, -38 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 2 chunks +28 lines, -10 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bsalomon
6 years, 8 months ago (2014-04-08 21:45:38 UTC) #1
jvanverth1
In general looks okay, just one comment: https://codereview.chromium.org/220233011/diff/80001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/220233011/diff/80001/src/gpu/GrOvalRenderer.cpp#newcode951 src/gpu/GrOvalRenderer.cpp:951: SkStrokeRec::Style style ...
6 years, 8 months ago (2014-04-09 17:26:06 UTC) #2
bsalomon
https://codereview.chromium.org/220233011/diff/80001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/220233011/diff/80001/src/gpu/GrOvalRenderer.cpp#newcode951 src/gpu/GrOvalRenderer.cpp:951: SkStrokeRec::Style style = stroke.getStyle(); On 2014/04/09 17:26:06, JimVV wrote: ...
6 years, 8 months ago (2014-04-09 19:23:25 UTC) #3
jvanverth1
lgtm
6 years, 8 months ago (2014-04-09 19:52:39 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-09 19:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/220233011/100001
6 years, 8 months ago (2014-04-09 19:56:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 20:01:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 8 months ago (2014-04-09 20:01:42 UTC) #8
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-09 20:08:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/220233011/120001
6 years, 8 months ago (2014-04-09 20:08:50 UTC) #10
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 8 months ago (2014-04-09 20:10:46 UTC) #11
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-09 20:10:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/220233011/120001
6 years, 8 months ago (2014-04-09 20:11:02 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:26:15 UTC) #14
Message was sent while issue was closed. 
Change committed as 14118

Powered by Google App Engine
This is Rietveld 408576698