Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2201993002: Don't invalidate resolution for ClassElementDelta annotation changes. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't invalidate resolution for ClassElementDelta annotation changes. I was wrong - @deprecated hints are already reported outside of resolution. The problem in incremental invalidation was fixed by updating ClassElement.metadata. So, now we can invalidate just errors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bc476100c4a324e9fdcb4d0bf4d03e1a184293cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +8 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-01 21:31:46 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-01 21:34:04 UTC) #2
scheglov
4 years, 4 months ago (2016-08-01 21:34:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc476100c4a324e9fdcb4d0bf4d03e1a184293cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698