Issue 2201993002: Don't invalidate resolution for ClassElementDelta annotation changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2201993002: Don't invalidate resolution for ClassElementDelta annotation changes. (Closed)

Created:
4 years, 4 months ago by scheglov

Modified:
4 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't invalidate resolution for ClassElementDelta annotation changes. I was wrong - @deprecated hints are already reported outside of resolution. The problem in incremental invalidation was fixed by updating ClassElement.metadata. So, now we can invalidate just errors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bc476100c4a324e9fdcb4d0bf4d03e1a184293cd

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		2 chunks	+8 lines, -11 lines	0 comments	Download
	M	pkg/analyzer/test/src/context/context_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 4 months ago (2016-08-01 21:34:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc476100c4a324e9fdcb4d0bf4d03e1a184293cd (presubmit successful).