Don't invalidate resolution for ClassElementDelta annotation changes.

pkg/analyzer/lib/src/task/dart.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 2615 matching lines @@
 
   bool hasAffectedHintsVerifyErrors(
       ReferencedNames references, Source refLibrary) {
     for (String superName in references.superToSubs.keys) {
       if (isChangedOrClass(refLibrary, superName)) {
         _log(() => '$refLibrary hints/verify errors are affected because '
             '${references.superToSubs[superName]} subclasses $superName');
         return true;
       }
     }
+    for (String name in references.names) {
+      ClassElementDelta classDelta = changedClasses[name];
+      if (classDelta != null && classDelta.hasAnnotationChanges) {
+        _log(() => '$refLibrary hints/verify errors are  affected because '
+            '$name has a class delta with annotation changes');
+        return true;
+      }
+    }
     return false;
   }
 
   bool hasAffectedReferences(ReferencedNames references, Source refLibrary) {
     // Resolution must be performed when a referenced element changes.
     for (String name in references.names) {
       if (isChangedOrClassMember(refLibrary, name)) {
         _log(() => '$refLibrary is affected by $name');
         return true;
       }
@@ skipping 12 matching lines @@
     }
     for (String name in references.extendedUsedUnnamedConstructorNames) {
       for (ClassElementDelta classDelta in changedClasses.values) {
         if (classDelta.name == name && classDelta.hasUnnamedConstructorChange) {
           _log(() =>
               '$refLibrary is affected by the default constructor of $name');
           return true;
         }
       }
     }
-    // TODO(scheglov) We don't need to invalidate resolution.
-    // We could just invalidate errors if we moved reporting of
-    // HintCode.DEPRECATED_MEMBER_USE from resolver to verifier.
-    for (String name in references.names) {
-        ClassElementDelta classDelta = changedClasses[name];
-        if (classDelta != null && classDelta.hasAnnotationChanges) {
-            _log(() => '$refLibrary is affected because '
-                '$name has a class delta with annotation changes');
-            return true;
-        }
-    }
     return false;
   }
 
   /**
    * Return `true` if the given [name], used in a unit of the [librarySource],
    * is affected by a changed top-level element, excluding classes.
    */
   bool isChanged(Source librarySource, String name) {
     if (_isPrivateName(name)) {
       if (changedPrivateNames[librarySource]?.contains(name) ?? false) {
@@ skipping 3884 matching lines @@
 
   @override
   bool moveNext() {
     if (_newSources.isEmpty) {
       return false;
     }
     currentTarget = _newSources.removeLast();
     return true;
   }
 }