Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2201993002: Don't invalidate resolution for ClassElementDelta annotation changes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 13e7b89620c4ff97579f37ebd22240d46fe09525..3309b544998eb80d03daa99744007023d7ba2b7b 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -2633,6 +2633,14 @@ class DartDelta extends Delta {
return true;
}
}
+ for (String name in references.names) {
+ ClassElementDelta classDelta = changedClasses[name];
+ if (classDelta != null && classDelta.hasAnnotationChanges) {
+ _log(() => '$refLibrary hints/verify errors are affected because '
+ '$name has a class delta with annotation changes');
+ return true;
+ }
+ }
return false;
}
@@ -2665,17 +2673,6 @@ class DartDelta extends Delta {
}
}
}
- // TODO(scheglov) We don't need to invalidate resolution.
- // We could just invalidate errors if we moved reporting of
- // HintCode.DEPRECATED_MEMBER_USE from resolver to verifier.
- for (String name in references.names) {
- ClassElementDelta classDelta = changedClasses[name];
- if (classDelta != null && classDelta.hasAnnotationChanges) {
- _log(() => '$refLibrary is affected because '
- '$name has a class delta with annotation changes');
- return true;
- }
- }
return false;
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698