Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 220163006: Begin simplifying CompositedLayerMapping::updateAfterLayout (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan_chormium.org, Ian Vollick
Visibility:
Public.

Description

Begin simplifying CompositedLayerMapping::updateAfterLayout This CL unpacks the arguments to updateAfterLayout from being a bit field to being separate Boolean values. As part of that unpacking, I learned that one of the bits is always set, which let me remove an argument to updateCompositingDescendantGeometry because it was always the same. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170610

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -7 lines 1 comment Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
6 years, 8 months ago (2014-04-01 19:54:31 UTC) #1
eseidel
rslgtm. However if you're looking for someone to be surprised that that argument is not ...
6 years, 8 months ago (2014-04-01 19:56:23 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 19:57:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220163006/1
6 years, 8 months ago (2014-04-01 19:57:47 UTC) #4
abarth-chromium
On 2014/04/01 19:56:23, eseidel wrote: > rslgtm. However if you're looking for someone to be ...
6 years, 8 months ago (2014-04-01 19:57:53 UTC) #5
ojan
lgtm https://codereview.chromium.org/220163006/diff/1/Source/core/rendering/compositing/CompositedLayerMapping.h File Source/core/rendering/compositing/CompositedLayerMapping.h (right): https://codereview.chromium.org/220163006/diff/1/Source/core/rendering/compositing/CompositedLayerMapping.h#newcode88 Source/core/rendering/compositing/CompositedLayerMapping.h:88: void updateAfterLayout(bool needsFullRepaint, bool isUpdateRoot); <3 this cleanup.
6 years, 8 months ago (2014-04-01 21:32:58 UTC) #6
abarth-chromium
On 2014/04/01 21:32:58, ojan wrote: > <3 this cleanup. Wait until you see the later ...
6 years, 8 months ago (2014-04-01 21:43:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220163006/1
6 years, 8 months ago (2014-04-01 22:21:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220163006/1
6 years, 8 months ago (2014-04-01 22:41:50 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 23:52:00 UTC) #10
Message was sent while issue was closed.
Change committed as 170610

Powered by Google App Engine
This is Rietveld 408576698