Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2201423003:
[Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. (Closed)
Description[Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item.
Add a test to check whether the "Enable cloud services" item is currently checked or not.
Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently.
Patch: https://codereview.chromium.org/2190223002
BUG=623330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/efa5e4609725d61ef253b54cd45762baba8b9020
Cr-Commit-Position: refs/heads/master@{#410605}
Patch Set 1 #Patch Set 2 : Add friend test. #
Total comments: 2
Messages
Total messages: 20 (14 generated)
Description was changed from ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c Cr-Commit-Position: refs/heads/master@{#408640} patch from issue 2190223002 at patchset 60001 (http://crrev.com/2190223002#ps60001) ========== to ========== [Reland] Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
Description was changed from ========== [Reland] Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Reland] Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
apacible@chromium.org changed reviewers: + msw@chromium.org
PTAL, thanks!
Description was changed from ========== [Reland] Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm with a nit https://codereview.chromium.org/2201423003/diff/40001/chrome/browser/ui/toolb... File chrome/browser/ui/toolbar/media_router_contextual_menu.h (right): https://codereview.chromium.org/2201423003/diff/40001/chrome/browser/ui/toolb... chrome/browser/ui/toolbar/media_router_contextual_menu.h:24: FRIEND_TEST_ALL_PREFIXES(MediaRouterContextualMenuUnitTest, nit: I'd rather see a static cast to a ui::SimpleMenuModel::Delegate in the test, or making those overrides public, than adding a friend test like this. It's not a big deal, go with your preference.
https://codereview.chromium.org/2201423003/diff/40001/chrome/browser/ui/toolb... File chrome/browser/ui/toolbar/media_router_contextual_menu.h (right): https://codereview.chromium.org/2201423003/diff/40001/chrome/browser/ui/toolb... chrome/browser/ui/toolbar/media_router_contextual_menu.h:24: FRIEND_TEST_ALL_PREFIXES(MediaRouterContextualMenuUnitTest, On 2016/08/08 18:07:11, msw wrote: > nit: I'd rather see a static cast to a ui::SimpleMenuModel::Delegate in the > test, or making those overrides public, than adding a friend test like this. > It's not a big deal, go with your preference. Thanks. We've been using friend tests for other Media Router tests, so keeping as is.
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. Previous patch was reverted as it broke official bots. I removed the friend test declaration inadvertently. Patch: https://codereview.chromium.org/2190223002 BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/efa5e4609725d61ef253b54cd45762baba8b9020 Cr-Commit-Position: refs/heads/master@{#410605} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/efa5e4609725d61ef253b54cd45762baba8b9020 Cr-Commit-Position: refs/heads/master@{#410605} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
