[Reland] [Media Router Contextual Menu] Test 'checked' state of cloud services item.

chrome/browser/ui/toolbar/media_router_contextual_menu.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_CONTEXTUAL_MENU_H_
 #define CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_CONTEXTUAL_MENU_H_
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/base/models/simple_menu_model.h"
 
 class Browser;
 
 // The class for the contextual menu for the Media Router action.
 class MediaRouterContextualMenu : public ui::SimpleMenuModel::Delegate {
  public:
   explicit MediaRouterContextualMenu(Browser* browser);
   ~MediaRouterContextualMenu() override;
 
   ui::MenuModel* menu_model() { return &menu_model_; }
 
  private:
+#if defined(GOOGLE_CHROME_BUILD)
+  FRIEND_TEST_ALL_PREFIXES(MediaRouterContextualMenuUnitTest,

[msw, 2016/08/08 18:07:11]

nit: I'd rather see a static cast to a ui::SimpleMenuModel::Delegate in the
test, or making those overrides public, than adding a friend test like this.
It's not a big deal, go with your preference.

[apacible, 2016/08/09 06:21:39]

Thanks. We've been using friend tests for other Media Router tests, so keeping
as is.

+                           ToggleCloudServicesItem);
+#endif  // GOOGLE_CHROME_BUILD
+
   // ui::SimpleMenuModel::Delegate:
   bool IsCommandIdChecked(int command_id) const override;
   bool IsCommandIdEnabled(int command_id) const override;
   bool IsCommandIdVisible(int command_id) const override;
   void ExecuteCommand(int command_id, int event_flags) override;
 
   void ReportIssue();
   void RemoveMediaRouterComponentAction();
 
   Browser* browser_;
   ui::SimpleMenuModel menu_model_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterContextualMenu);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_CONTEXTUAL_MENU_H_