Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2190223002:
[Media Router Contextual Menu] Test 'checked' state of cloud services item. (Closed)
Description[Media Router Contextual Menu] Test 'checked' state of cloud services item.
Add a test to check whether the "Enable cloud services" item is currently checked or not.
BUG=623330
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c
Cr-Commit-Position: refs/heads/master@{#408640}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Changes per msw@'s comments. #Messages
Total messages: 30 (23 generated)
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Description was changed from ========== tests BUG= ========== to ========== tests BUG=623330 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== tests BUG=623330 ========== to ========== [Media Router Contextual Menu] Check 'checked' state of cloud services item. BUG=623330 ==========
Description was changed from ========== [Media Router Contextual Menu] Check 'checked' state of cloud services item. BUG=623330 ========== to ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
apacible@chromium.org changed reviewers: + msw@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with a nit https://codereview.chromium.org/2190223002/diff/20001/chrome/browser/ui/toolb... File chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc (right): https://codereview.chromium.org/2190223002/diff/20001/chrome/browser/ui/toolb... chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc:98: // Create the delegate for this test. nit: Create the MediaRouterContextualMenu ui::SimpleMenuModel::Delegate here. (i wasn't sure what you meant by 'delegate' until I looked up the class)
Description was changed from ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 ========== to ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2190223002/diff/20001/chrome/browser/ui/toolb... File chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc (right): https://codereview.chromium.org/2190223002/diff/20001/chrome/browser/ui/toolb... chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc:98: // Create the delegate for this test. On 2016/07/29 02:31:50, msw wrote: > nit: Create the MediaRouterContextualMenu ui::SimpleMenuModel::Delegate here. > (i wasn't sure what you meant by 'delegate' until I looked up the class) Done.
The CQ bit was checked by apacible@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org Link to the patchset: https://codereview.chromium.org/2190223002/#ps60001 (title: "Changes per msw@'s comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [Media Router Contextual Menu] Test 'checked' state of cloud services item. Add a test to check whether the "Enable cloud services" item is currently checked or not. BUG=623330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c Cr-Commit-Position: refs/heads/master@{#408640} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5dc8d635fceca17f8bf56044865ae4afb462f48c Cr-Commit-Position: refs/heads/master@{#408640}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in https://codereview.chromium.org/2196453004/ by apacible@chromium.org. The reason for reverting is: Broke official build..
Message was sent while issue was closed.
Patchset #3 (id:80001) has been deleted |
