Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: content/shell/browser/shell_content_browser_client.cc

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clang compile errors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_browser_main_parts.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_content_browser_client.cc
diff --git a/content/shell/browser/shell_content_browser_client.cc b/content/shell/browser/shell_content_browser_client.cc
index 2f522b40a170f9f3114f70b9f8ebe073237fdd0c..5fe4483d0466b298b80cedd8bb3cac0c8e8d583b 100644
--- a/content/shell/browser/shell_content_browser_client.cc
+++ b/content/shell/browser/shell_content_browser_client.cc
@@ -297,18 +297,8 @@ void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
regions->insert(std::make_pair(
kShellPakDescriptor,
base::GlobalDescriptors::GetInstance()->GetRegion(kShellPakDescriptor)));
-
- if (breakpad::IsCrashReporterEnabled()) {
Torne 2016/08/03 16:33:48 Where did this condition (and the equivalent in th
- base::File f(breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id));
- if (!f.IsValid()) {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- << "be disabled for this process.";
- } else {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(f.TakePlatformFile()));
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
}
#elif defined(OS_POSIX) && !defined(OS_MACOSX)
void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
« no previous file with comments | « content/shell/browser/shell_browser_main_parts.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698