Refactor CrashDump*Manager to use a shared CrashDumpObserver.

content/shell/browser/shell_content_browser_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/shell_content_browser_client.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/base_switches.h"
@@ skipping 279 matching lines @@
     const base::CommandLine& command_line,
     int child_process_id,
     content::FileDescriptorInfo* mappings,
     std::map<int, base::MemoryMappedFile::Region>* regions) {
   mappings->Share(
       kShellPakDescriptor,
       base::GlobalDescriptors::GetInstance()->Get(kShellPakDescriptor));
   regions->insert(std::make_pair(
       kShellPakDescriptor,
       base::GlobalDescriptors::GetInstance()->GetRegion(kShellPakDescriptor)));
-
-  if (breakpad::IsCrashReporterEnabled()) {

[Torne, 2016/08/03 16:33:48]

Where did this condition (and the equivalent in the other files)go? I can't spot
it in the new code, maybe I'm missing something?

-    base::File f(breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
-        child_process_id));
-    if (!f.IsValid()) {
-      LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
-                 << "be disabled for this process.";
-    } else {
-      mappings->Transfer(kAndroidMinidumpDescriptor,
-                         base::ScopedFD(f.TakePlatformFile()));
-    }
-  }
+  breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+      child_process_id, mappings);
 }
 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
 void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
     const base::CommandLine& command_line,
     int child_process_id,
     content::FileDescriptorInfo* mappings) {
   int crash_signal_fd = GetCrashSignalFD(command_line);
   if (crash_signal_fd >= 0) {
     mappings->Share(kCrashDumpSignal, crash_signal_fd);
   }
@@ skipping 20 matching lines @@
 ShellBrowserContext* ShellContentBrowserClient::browser_context() {
   return shell_browser_main_parts_->browser_context();
 }
 
 ShellBrowserContext*
     ShellContentBrowserClient::off_the_record_browser_context() {
   return shell_browser_main_parts_->off_the_record_browser_context();
 }
 
 }  // namespace content