content/shell/browser/shell_browser_main_parts.cc - Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_browser_main_parts.cc

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clang compile errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_browser_main_parts.h ('k') | content/shell/browser/shell_content_browser_client.cc » ('j') | content/shell/browser/shell_content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_browser_main_parts.cc

diff --git a/content/shell/browser/shell_browser_main_parts.cc b/content/shell/browser/shell_browser_main_parts.cc

index ae1f590c1c146493f6d7103847874c94197915c8..08f60692ffd5a05eef4bf0f402be4396e4a33678 100644

--- a/content/shell/browser/shell_browser_main_parts.cc

+++ b/content/shell/browser/shell_browser_main_parts.cc

@@ -19,6 +19,7 @@

#include "content/public/common/content_switches.h"

#include "content/public/common/main_function_params.h"

#include "content/public/common/url_constants.h"

+#include "content/shell/android/shell_descriptors.h"

#include "content/shell/browser/shell.h"

#include "content/shell/browser/shell_access_token_store.h"

#include "content/shell/browser/shell_browser_context.h"

@@ -173,7 +174,9 @@ int ShellBrowserMainParts::PreCreateThreads() {

base::FilePath crash_dumps_dir =

base::CommandLine::ForCurrentProcess()->GetSwitchValuePath(

switches::kCrashDumpsDir);

- crash_dump_manager_.reset(new breakpad::CrashDumpManager(crash_dumps_dir));

+ breakpad::CrashDumpObserver::GetInstance()->RegisterClient(

+ base::MakeUnique<breakpad::CrashDumpManager>(

+ crash_dumps_dir, kAndroidMinidumpDescriptor));

}

return 0;