Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2200353002: Revert of services/ui: Have an explicit lifetime/ownership of ui::GpuService. (Closed)

Created:
4 years, 4 months ago by Mathieu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of services/ui: Have an explicit lifetime/ownership of ui::GpuService. (patchset #1 id:1 of https://codereview.chromium.org/2194003002/ ) Reason for revert: Hoping to fix failing RenderThreadImplBrowserTest failing. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/31741 Original issue's description: > services/ui: Have an explicit lifetime/ownership of ui::GpuService. > > BUG=none > > Committed: https://crrev.com/fa6c9e81dcc6cf69f8e0d927e66164d5f101214d > Cr-Commit-Position: refs/heads/master@{#409260} TBR=ben@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/5046c443e19fd22874742ca72b24706092f620dd Cr-Commit-Position: refs/heads/master@{#409327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M ash/mus/window_manager_application.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/ui/common/gpu_service.h View 2 chunks +4 lines, -3 lines 0 comments Download
M services/ui/common/gpu_service.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M services/ui/demo/mus_demo.h View 2 chunks +0 lines, -3 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mathieu
Created Revert of services/ui: Have an explicit lifetime/ownership of ui::GpuService.
4 years, 4 months ago (2016-08-02 21:24:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200353002/1
4 years, 4 months ago (2016-08-02 21:24:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 21:29:29 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 21:32:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5046c443e19fd22874742ca72b24706092f620dd
Cr-Commit-Position: refs/heads/master@{#409327}

Powered by Google App Engine
This is Rietveld 408576698