Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2194003002: services/ui: Have an explicit lifetime/ownership of ui::GpuService. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Have an explicit lifetime/ownership of ui::GpuService. BUG=none Committed: https://crrev.com/fa6c9e81dcc6cf69f8e0d927e66164d5f101214d Committed: https://crrev.com/9e0bb1d2ab5664dbce7ba3df8b629add2dc2c24e Cr-Original-Commit-Position: refs/heads/master@{#409260} Cr-Commit-Position: refs/heads/master@{#409885}

Patch Set 1 #

Patch Set 2 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M ash/mus/window_manager_application.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M services/ui/common/gpu_service.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/ui/common/gpu_service.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M services/ui/demo/mus_demo.h View 2 chunks +3 lines, -0 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
sadrul
4 years, 4 months ago (2016-07-30 01:18:32 UTC) #4
Ben Goodger (Google)
lgtm
4 years, 4 months ago (2016-08-02 17:18:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194003002/1
4 years, 4 months ago (2016-08-02 17:53:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 19:04:41 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa6c9e81dcc6cf69f8e0d927e66164d5f101214d Cr-Commit-Position: refs/heads/master@{#409260}
4 years, 4 months ago (2016-08-02 19:08:34 UTC) #12
Mathieu
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2200353002/ by mathp@chromium.org. ...
4 years, 4 months ago (2016-08-02 21:24:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194003002/20001
4 years, 4 months ago (2016-08-04 19:16:58 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 20:18:54 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 20:20:46 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e0bb1d2ab5664dbce7ba3df8b629add2dc2c24e
Cr-Commit-Position: refs/heads/master@{#409885}

Powered by Google App Engine
This is Rietveld 408576698