Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context.cc

Issue 2200263002: CL #2204863002 for M52: Ensure push permission is denied when dismissed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_permission_context.cc
diff --git a/chrome/browser/push_messaging/push_messaging_permission_context.cc b/chrome/browser/push_messaging/push_messaging_permission_context.cc
index f5591c26faeba9bab26117e7fa51b77fbf57bd05..38bb918fa0cb938621c85eec58f382526a362e95 100644
--- a/chrome/browser/push_messaging/push_messaging_permission_context.cc
+++ b/chrome/browser/push_messaging/push_messaging_permission_context.cc
@@ -107,7 +107,6 @@ void PushMessagingPermissionContext::DecidePushPermission(
const BrowserPermissionCallback& callback,
blink::mojom::PermissionStatus notification_status) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- DCHECK_NE(notification_status, blink::mojom::PermissionStatus::ASK);
ContentSetting push_content_setting =
HostContentSettingsMapFactory::GetForProfile(profile_)
@@ -123,7 +122,7 @@ void PushMessagingPermissionContext::DecidePushPermission(
return;
}
- if (notification_status == blink::mojom::PermissionStatus::DENIED) {
+ if (notification_status != blink::mojom::PermissionStatus::GRANTED) {
DVLOG(1) << "Notification permission has not been granted.";
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
false /* persist */, CONTENT_SETTING_BLOCK);
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698