Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

Issue 2200263002: CL #2204863002 for M52: Ensure push permission is denied when dismissed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_permission_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
index e77c100eb0233e5dbee2e62e27b3e290c4c38388..e7bf1cf6bd6f9fdbd78eed47b0733ae62cfd8d13 100644
--- a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
+++ b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
@@ -164,6 +164,11 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {
BrowserPermissionCallback callback = base::Bind(DoNothing);
context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
+ callback, blink::mojom::PermissionStatus::ASK);
+ EXPECT_FALSE(context.was_persisted());
+ EXPECT_FALSE(context.was_granted());
+
+ context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
callback,
blink::mojom::PermissionStatus::DENIED);
EXPECT_FALSE(context.was_persisted());
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_permission_context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698