Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: chrome/browser/push_messaging/push_messaging_permission_context.cc

Issue 2200263002: CL #2204863002 for M52: Ensure push permission is denied when dismissed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/push_messaging/push_messaging_permission_context.h" 5 #include "chrome/browser/push_messaging/push_messaging_permission_context.h"
6 6
7 #include "chrome/browser/content_settings/host_content_settings_map_factory.h" 7 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
8 #include "chrome/browser/permissions/permission_manager.h" 8 #include "chrome/browser/permissions/permission_manager.h"
9 #include "chrome/browser/permissions/permission_request_id.h" 9 #include "chrome/browser/permissions/permission_request_id.h"
10 #include "chrome/browser/permissions/permission_uma_util.h" 10 #include "chrome/browser/permissions/permission_uma_util.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 return true; 100 return true;
101 } 101 }
102 102
103 void PushMessagingPermissionContext::DecidePushPermission( 103 void PushMessagingPermissionContext::DecidePushPermission(
104 const PermissionRequestID& id, 104 const PermissionRequestID& id,
105 const GURL& requesting_origin, 105 const GURL& requesting_origin,
106 const GURL& embedding_origin, 106 const GURL& embedding_origin,
107 const BrowserPermissionCallback& callback, 107 const BrowserPermissionCallback& callback,
108 blink::mojom::PermissionStatus notification_status) { 108 blink::mojom::PermissionStatus notification_status) {
109 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 109 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
110 DCHECK_NE(notification_status, blink::mojom::PermissionStatus::ASK);
111 110
112 ContentSetting push_content_setting = 111 ContentSetting push_content_setting =
113 HostContentSettingsMapFactory::GetForProfile(profile_) 112 HostContentSettingsMapFactory::GetForProfile(profile_)
114 ->GetContentSettingAndMaybeUpdateLastUsage( 113 ->GetContentSettingAndMaybeUpdateLastUsage(
115 requesting_origin, embedding_origin, content_settings_type(), 114 requesting_origin, embedding_origin, content_settings_type(),
116 std::string()); 115 std::string());
117 116
118 if (push_content_setting == CONTENT_SETTING_BLOCK) { 117 if (push_content_setting == CONTENT_SETTING_BLOCK) {
119 DVLOG(1) << "Push permission was explicitly blocked."; 118 DVLOG(1) << "Push permission was explicitly blocked.";
120 PermissionUmaUtil::PermissionDenied(permission_type(), requesting_origin); 119 PermissionUmaUtil::PermissionDenied(permission_type(), requesting_origin);
121 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 120 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
122 true /* persist */, CONTENT_SETTING_BLOCK); 121 true /* persist */, CONTENT_SETTING_BLOCK);
123 return; 122 return;
124 } 123 }
125 124
126 if (notification_status == blink::mojom::PermissionStatus::DENIED) { 125 if (notification_status != blink::mojom::PermissionStatus::GRANTED) {
127 DVLOG(1) << "Notification permission has not been granted."; 126 DVLOG(1) << "Notification permission has not been granted.";
128 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 127 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
129 false /* persist */, CONTENT_SETTING_BLOCK); 128 false /* persist */, CONTENT_SETTING_BLOCK);
130 return; 129 return;
131 } 130 }
132 131
133 PermissionUmaUtil::PermissionGranted(permission_type(), requesting_origin); 132 PermissionUmaUtil::PermissionGranted(permission_type(), requesting_origin);
134 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 133 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
135 true /* persist */, CONTENT_SETTING_ALLOW); 134 true /* persist */, CONTENT_SETTING_ALLOW);
136 } 135 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698