Issue 2200263002: CL #2204863002 for M52: Ensure push permission is denied when dismissed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2200263002: CL #2204863002 for M52: Ensure push permission is denied when dismissed (Closed)

Created:
4 years, 4 months ago by Peter Beverloo

Modified:
4 years, 4 months ago

Reviewers:
raymes

CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, johnme+watch_chromium.org, harkness+watch_chromium.org, mvanouwerkerk+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

CL #2204863002 for M52: Ensure push permission is denied when dismissed This is Raymes' CL on top of the 2743 branch, originally uploaded here: https://codereview.chromium.org/2204863002/ BUG=633310 R=raymes@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/37145ff4b449471ced08b452a5e110a5375f9a2e

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/push_messaging/push_messaging_permission_context.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Beverloo

4 years, 4 months ago (2016-08-02 19:21:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
37145ff4b449471ced08b452a5e110a5375f9a2e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages