Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2199953002: Add CLIENT_REDIRECT variants for page load metrics abort types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aborts
Patch Set: fix histogram name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index 477362136ec63faaa85a3dc98bd31a36039c4dcd..6f6a8015d7cb5de958d574bb584c45dcfce36fff 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -348,3 +348,32 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
histogram_tester_.ExpectTotalCount(
internal::kHistogramAbortNewNavigationBeforeCommit, 2);
}
+
+IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
+ AbortClientRedirect) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ GURL first_url(embedded_test_server()->GetURL("/title1.html"));
+ ui_test_utils::NavigateToURL(browser(), first_url);
+
+ GURL second_url(embedded_test_server()->GetURL("/title2.html"));
+ chrome::NavigateParams params(browser(), second_url,
+ ui::PAGE_TRANSITION_LINK);
+ content::TestNavigationManager manager(
+ browser()->tab_strip_model()->GetActiveWebContents(), second_url);
+ chrome::Navigate(&params);
+ EXPECT_TRUE(manager.WaitForWillStartRequest());
+
+ {
+ content::TestNavigationManager reload_manager(
+ browser()->tab_strip_model()->GetActiveWebContents(), first_url);
+ EXPECT_TRUE(content::ExecuteScript(
+ browser()->tab_strip_model()->GetActiveWebContents(),
+ "window.location.reload();"));
+ }
+
+ manager.WaitForNavigationFinished();
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kHistogramAbortClientRedirectBeforeCommit, 1);
+}

Powered by Google App Engine
This is Rietveld 408576698