Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3003)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2199953002: Add CLIENT_REDIRECT variants for page load metrics abort types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aborts
Patch Set: fix histogram name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 28e31d04413049ce5fb4bfdc0e95816a70c4d9c2..f6c32ab15afad0d6e1cd05c11ea0a97440e92acc 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -10,6 +10,8 @@ using page_load_metrics::UserAbortType;
namespace internal {
+const char kHistogramAbortClientRedirectBeforeCommit[] =
+ "PageLoad.AbortTiming.ClientRedirect.BeforeCommit";
const char kHistogramAbortForwardBackBeforeCommit[] =
"PageLoad.AbortTiming.ForwardBackNavigation.BeforeCommit";
const char kHistogramAbortReloadBeforeCommit[] =
@@ -23,6 +25,8 @@ const char kHistogramAbortCloseBeforeCommit[] =
const char kHistogramAbortOtherBeforeCommit[] =
"PageLoad.AbortTiming.Other.BeforeCommit";
+const char kHistogramAbortClientRedirectBeforePaint[] =
+ "PageLoad.AbortTiming.ClientRedirect.AfterCommit.BeforePaint";
const char kHistogramAbortForwardBackBeforePaint[] =
"PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint";
const char kHistogramAbortReloadBeforePaint[] =
@@ -34,6 +38,8 @@ const char kHistogramAbortStopBeforePaint[] =
const char kHistogramAbortCloseBeforePaint[] =
"PageLoad.AbortTiming.Close.AfterCommit.BeforePaint";
+const char kHistogramAbortClientRedirectDuringParse[] =
+ "PageLoad.AbortTiming.ClientRedirect.DuringParse";
const char kHistogramAbortForwardBackDuringParse[] =
"PageLoad.AbortTiming.ForwardBackNavigation.DuringParse";
const char kHistogramAbortReloadDuringParse[] =
@@ -60,6 +66,10 @@ void RecordAbortBeforeCommit(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortForwardBackBeforeCommit,
time_to_abort);
return;
+ case UserAbortType::ABORT_CLIENT_REDIRECT:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortClientRedirectBeforeCommit,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_NEW_NAVIGATION:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortNewNavigationBeforeCommit,
time_to_abort);
@@ -95,6 +105,10 @@ void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortForwardBackBeforePaint,
time_to_abort);
return;
+ case UserAbortType::ABORT_CLIENT_REDIRECT:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortClientRedirectBeforePaint,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_NEW_NAVIGATION:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortNewNavigationBeforePaint,
time_to_abort);
@@ -129,6 +143,10 @@ void RecordAbortDuringParse(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortForwardBackDuringParse,
time_to_abort);
return;
+ case UserAbortType::ABORT_CLIENT_REDIRECT:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortClientRedirectDuringParse,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_NEW_NAVIGATION:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortNewNavigationDuringParse,
time_to_abort);

Powered by Google App Engine
This is Rietveld 408576698