Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2199953002: Add CLIENT_REDIRECT variants for page load metrics abort types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aborts
Patch Set: fix histogram name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
8 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 8 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
9 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 9 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
10 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 10 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 chrome::Navigate(&params3); 341 chrome::Navigate(&params3);
342 342
343 EXPECT_TRUE(manager3.WaitForWillStartRequest()); 343 EXPECT_TRUE(manager3.WaitForWillStartRequest());
344 manager2.WaitForNavigationFinished(); 344 manager2.WaitForNavigationFinished();
345 345
346 manager3.WaitForNavigationFinished(); 346 manager3.WaitForNavigationFinished();
347 347
348 histogram_tester_.ExpectTotalCount( 348 histogram_tester_.ExpectTotalCount(
349 internal::kHistogramAbortNewNavigationBeforeCommit, 2); 349 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
350 } 350 }
351
352 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
353 AbortClientRedirect) {
354 ASSERT_TRUE(embedded_test_server()->Start());
355
356 GURL first_url(embedded_test_server()->GetURL("/title1.html"));
357 ui_test_utils::NavigateToURL(browser(), first_url);
358
359 GURL second_url(embedded_test_server()->GetURL("/title2.html"));
360 chrome::NavigateParams params(browser(), second_url,
361 ui::PAGE_TRANSITION_LINK);
362 content::TestNavigationManager manager(
363 browser()->tab_strip_model()->GetActiveWebContents(), second_url);
364 chrome::Navigate(&params);
365 EXPECT_TRUE(manager.WaitForWillStartRequest());
366
367 {
368 content::TestNavigationManager reload_manager(
369 browser()->tab_strip_model()->GetActiveWebContents(), first_url);
370 EXPECT_TRUE(content::ExecuteScript(
371 browser()->tab_strip_model()->GetActiveWebContents(),
372 "window.location.reload();"));
373 }
374
375 manager.WaitForNavigationFinished();
376
377 histogram_tester_.ExpectTotalCount(
378 internal::kHistogramAbortClientRedirectBeforeCommit, 1);
379 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698