Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2199643003: binding: Uses the current context if attribute/method is static. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Uses the current context if attribute/method is static. https://crrev.com/2049493005 did not care about static attributes / methods. This CL takes care of "static". BUG=632634 Committed: https://crrev.com/3506b0ab25762c3770512385ce232c6ece7ccf6b Cr-Commit-Position: refs/heads/master@{#408945}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Messages

Total messages: 12 (7 generated)
Yuki
Could you review this CL?
4 years, 4 months ago (2016-08-01 09:34:59 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-01 09:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199643003/40001
4 years, 4 months ago (2016-08-01 10:50:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 12:23:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 12:26:09 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3506b0ab25762c3770512385ce232c6ece7ccf6b
Cr-Commit-Position: refs/heads/master@{#408945}

Powered by Google App Engine
This is Rietveld 408576698