third_party/WebKit/Source/bindings/templates/methods.cpp - Issue 2199643003: binding: Uses the current context if attribute/method is static.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/methods.cpp

Issue 2199643003: binding: Uses the current context if attribute/method is static. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/methods.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/methods.cpp b/third_party/WebKit/Source/bindings/templates/methods.cpp

index 0ebe28af715ef708c165bda384d0836663ed42bf..c3805dcbd7cf17271c1580d42439f6e6f5588b33 100644

--- a/third_party/WebKit/Source/bindings/templates/methods.cpp

+++ b/third_party/WebKit/Source/bindings/templates/methods.cpp

@@ -233,7 +233,11 @@ if (!{{argument.name}}.isUndefinedOrNull() && !{{argument.name}}.isObject()) {

{% if method.is_call_with_script_state or method.is_call_with_this_value %}

{# [ConstructorCallWith=ScriptState] #}

{# [CallWith=ScriptState] #}

-ScriptState* scriptState = ScriptState::forHolderObject(info);

+{% if method.is_static %}

+ScriptState* scriptState = ScriptState::forFunctionObject(info);

+{% else %}

+ScriptState* scriptState = ScriptState::forReceiverObject(info);

+{% endif %}

{% endif %}

{% if method.is_call_with_execution_context %}

{# [ConstructorCallWith=ExecutionContext] #}

@@ -502,7 +506,11 @@ static void {{method.name}}MethodCallback{{world_suffix}}(const v8::FunctionCall

{% endif %}

{% endif %}{# not method.overloads #}

{% if world_suffix in method.activity_logging_world_list %}

- ScriptState* scriptState = ScriptState::forHolderObject(info);

+ {% if method.is_static %}

+ ScriptState* scriptState = ScriptState::forFunctionObject(info);

+ {% else %}

+ ScriptState* scriptState = ScriptState::forReceiverObject(info);

+ {% endif %}

V8PerContextData* contextData = scriptState->perContextData();

{% if method.activity_logging_world_check %}

if (scriptState->world().isIsolatedWorld() && contextData && contextData->activityLogger())