Do an access check before compiling code via eval()

Do an access check before compiling code via eval()

Similarly to how we check whether the entered context has access to the target
context when invoking the function constructor, we should check the involved
contexts before invoking eval().

I forgot to add this in the initial CL that adds the check for the function
constructor. Move the code to a common location, and use it for the GlobalEval
builtin as well.

BUG=chromium:541703
R=verwaest@chromium.org

Committed: https://crrev.com/2f8d4f44257f24e19b3cc98e8ad0de50a457c4cd
Cr-Commit-Position: refs/heads/master@{#38277}

[jochen (gone - plz use gerrit), 2016-08-02 15:11:51]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 15:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 15:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 15:15:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[jochen (gone - plz use gerrit), 2016-08-02 15:23:10]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 15:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-08-02 15:28:49]

ptal (now with green bots)

[commit-bot: I haz the power, 2016-08-02 15:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 15:39:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[adamk, 2016-08-02 16:58:48]

More CL description, please :)

[jochen (gone - plz use gerrit), 2016-08-02 18:37:00]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:37:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-08-02 18:39:31]

Description was changed from

==========
Forgot to also restrict eval()

BUG=chromium:541703
R=verwaest@chromium.org
==========

to

==========
Do an access check before compiling code via eval()

Similarly to how we check whether the entered context has access to the target
context when invoking the function constructor, we should check the involved
contexts before invoking eval().

I forgot to add this in the initial CL that adds the check for the function
constructor. Move the code to a common location, and use it for the GlobalEval
builtin as well.

BUG=chromium:541703
R=verwaest@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-08-02 18:39:36]

done

[commit-bot: I haz the power, 2016-08-02 19:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:00:21]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-08-02 20:46:21]

lgtm

[jochen (gone - plz use gerrit), 2016-08-03 07:40:15]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-08-03 07:40:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 07:42:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 07:42:59]

Description was changed from

==========
Do an access check before compiling code via eval()

Similarly to how we check whether the entered context has access to the target
context when invoking the function constructor, we should check the involved
contexts before invoking eval().

I forgot to add this in the initial CL that adds the check for the function
constructor. Move the code to a common location, and use it for the GlobalEval
builtin as well.

BUG=chromium:541703
R=verwaest@chromium.org
==========

to

==========
Do an access check before compiling code via eval()

Similarly to how we check whether the entered context has access to the target
context when invoking the function constructor, we should check the involved
contexts before invoking eval().

I forgot to add this in the initial CL that adds the check for the function
constructor. Move the code to a common location, and use it for the GlobalEval
builtin as well.

BUG=chromium:541703
R=verwaest@chromium.org

Committed: https://crrev.com/2f8d4f44257f24e19b3cc98e8ad0de50a457c4cd
Cr-Commit-Position: refs/heads/master@{#38277}
==========

[commit-bot: I haz the power, 2016-08-03 07:43:00]

Patchset 3 (id:??) landed as
https://crrev.com/2f8d4f44257f24e19b3cc98e8ad0de50a457c4cd
Cr-Commit-Position: refs/heads/master@{#38277}