Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: src/builtins/builtins.cc

Issue 2199343002: Do an access check before compiling code via eval() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/builtins/builtins-function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins.cc
diff --git a/src/builtins/builtins.cc b/src/builtins/builtins.cc
index 2ab234fc70781e1f8fee7d5750535c363bd95094..2188743fc5f5d5e40123d122ed0589bd52fb9f79 100644
--- a/src/builtins/builtins.cc
+++ b/src/builtins/builtins.cc
@@ -206,5 +206,22 @@ const char* Builtins::name(int index) {
BUILTIN_LIST_ALL(DEFINE_BUILTIN_ACCESSOR)
#undef DEFINE_BUILTIN_ACCESSOR
+// static
+bool Builtins::AllowDynamicFunction(Isolate* isolate, Handle<JSFunction> target,
+ Handle<JSObject> target_global_proxy) {
+ if (FLAG_allow_unsafe_function_constructor) return true;
+ HandleScopeImplementer* impl = isolate->handle_scope_implementer();
+ Handle<Context> responsible_context = impl->LastEnteredContext();
+ if (responsible_context.is_null()) {
+ responsible_context = impl->MicrotaskContext();
+ // TODO(jochen): Remove this.
+ if (responsible_context.is_null()) {
+ return true;
+ }
+ }
+ if (*responsible_context == target->context()) return true;
+ return isolate->MayAccess(responsible_context, target_global_proxy);
+}
+
} // namespace internal
} // namespace v8
« no previous file with comments | « src/builtins/builtins.h ('k') | src/builtins/builtins-function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698