Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: src/builtins/builtins-function.cc

Issue 2199343002: Do an access check before compiling code via eval() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.cc ('k') | src/builtins/builtins-global.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-function.cc
diff --git a/src/builtins/builtins-function.cc b/src/builtins/builtins-function.cc
index 6c3daf5c0160ff553bffa39f7cabd70b44635d12..0a631bff5cdb5242cb210cf5068936a53786e6b9 100644
--- a/src/builtins/builtins-function.cc
+++ b/src/builtins/builtins-function.cc
@@ -13,22 +13,6 @@ namespace internal {
namespace {
-bool AllowDynamicFunction(Isolate* isolate, Handle<JSFunction> target,
- Handle<JSObject> target_global_proxy) {
- if (FLAG_allow_unsafe_function_constructor) return true;
- HandleScopeImplementer* impl = isolate->handle_scope_implementer();
- Handle<Context> responsible_context = impl->LastEnteredContext();
- if (responsible_context.is_null()) {
- responsible_context = impl->MicrotaskContext();
- // TODO(jochen): Remove this.
- if (responsible_context.is_null()) {
- return true;
- }
- }
- if (*responsible_context == target->context()) return true;
- return isolate->MayAccess(responsible_context, target_global_proxy);
-}
-
// ES6 section 19.2.1.1.1 CreateDynamicFunction
MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
BuiltinArguments args,
@@ -40,7 +24,7 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
Handle<JSFunction> target = args.target<JSFunction>();
Handle<JSObject> target_global_proxy(target->global_proxy(), isolate);
- if (!AllowDynamicFunction(isolate, target, target_global_proxy)) {
+ if (!Builtins::AllowDynamicFunction(isolate, target, target_global_proxy)) {
isolate->CountUsage(v8::Isolate::kFunctionConstructorReturnedUndefined);
return isolate->factory()->undefined_value();
}
« no previous file with comments | « src/builtins/builtins.cc ('k') | src/builtins/builtins-global.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698