Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

Issue 2199273002: Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix platforms for GN Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json
diff --git a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json
index fcba352a20f5e94a38a37620211525f97c1c624e..a1a4510ab4584f9804177c6d8e4494c77b40e13c 100644
--- a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json
+++ b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json
@@ -84,6 +84,7 @@
],
"cwd": "[CUSTOM_/_B_WORK]",
"env": {
+ "CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
"name": "gclient runhooks"
@@ -151,34 +152,22 @@
},
{
"cmd": [
- "python",
- "-u",
- "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
- "runhooks"
- ],
- "cwd": "[CUSTOM_/_B_WORK]/skia",
- "env": {
- "CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",
- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
- },
- "name": "gclient runhooks (2)"
- },
- {
- "cmd": [
- "build/gyp_chromium"
+ "[CUSTOM_/_B_WORK]/src/buildtools/linux64/gn",
+ "gen",
+ "[CUSTOM_/_B_WORK]/src/out/Release"
],
"cwd": "[CUSTOM_/_B_WORK]/src",
"env": {
"CPPFLAGS": "-DSK_ALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS=1",
"GYP_GENERATORS": "ninja"
},
- "name": "gyp_chromium"
+ "name": "GN"
},
{
"cmd": [
"ninja",
"-C",
- "out/Release",
+ "[CUSTOM_/_B_WORK]/src/out/Release",
"chrome"
],
"cwd": "[CUSTOM_/_B_WORK]/src",

Powered by Google App Engine
This is Rietveld 408576698