Remove unnecessary page loading in ContentShellActivity

Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419, 179511
Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
Committed: https://crrev.com/6554045543b20db3e810925f3cda0f0d93e4bae6
Cr-Original-Commit-Position: refs/heads/master@{#410519}
Cr-Commit-Position: refs/heads/master@{#411250}

[yabinh, 2016-08-02 06:00:36]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 06:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-08-02 06:03:40]

Description was changed from

==========
Fix flaky setUp() in ImeTest

setUp() was flaky because we were reaching the element before it’s ready.
To make sure that, we should wait until the page stops loading, and
shell’s view is ready to draw contents to the screen.
assertWaitForPageScaleFactorMatch() was a workaround for some flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate of
ImeTest. (Nexus 5: 3/20,000, Nexus 9: 21/1,100).
After applying this patch, the failure rate of ImeTest is 0/6000+, and
0/10000 of other tests in total, all on Nexus 9.

BUG=580419
==========

to

==========
Fix flaky setUp() in ImeTest

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading,
and shell’s view is ready to draw contents to the screen.
assertWaitForPageScaleFactorMatch() was a workaround for some flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate of
ImeTest. (Nexus 5: 3/20,000, Nexus 9: 21/1,100).
After applying this patch, the failure rate of ImeTest is 0/6000+, and
0/10000 of other tests in total, all on Nexus 9.

BUG=580419
==========

[yabinh, 2016-08-02 06:03:40]

yabinh@chromium.org changed reviewers:
+ aelias@chromium.org, changwan@chromium.org

[yabinh, 2016-08-02 06:21:58]

changwan@, please take a look at this cl.

[commit-bot: I haz the power, 2016-08-02 06:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 06:30:37]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2016-08-02 06:36:44]

changwan@chromium.org changed reviewers:
+ sievers@chromium.org

[Changwan Ryu, 2016-08-02 06:36:44]

non-owner lgtm

adding sievers@ for OWNERS

[yabinh, 2016-08-02 09:04:15]

Description was changed from

==========
Fix flaky setUp() in ImeTest

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading,
and shell’s view is ready to draw contents to the screen.
assertWaitForPageScaleFactorMatch() was a workaround for some flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate of
ImeTest. (Nexus 5: 3/20,000, Nexus 9: 21/1,100).
After applying this patch, the failure rate of ImeTest is 0/6000+, and
0/10000 of other tests in total, all on Nexus 9.

BUG=580419
==========

to

==========
Fix flaky setUp() in those tests related to 
ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:04:50]

Description was changed from

==========
Fix flaky setUp() in those tests related to 
ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to 
ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:05:04]

Description was changed from

==========
Fix flaky setUp() in tests related to 
ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:07:13]

Description was changed from

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stops loading 
and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() was a workaround for the flaky
tests (crbug.com/179511). They are not flaky anymore after applying this
patch. Thus, we can remove the function.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround 
for
crbug.com/179511 . They are not flaky anymore after applying this
patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:07:39]

Description was changed from

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround 
for
crbug.com/179511 . They are not flaky anymore after applying this
patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . They are not flaky anymore after applying this
patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:08:27]

Description was changed from

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . They are not flaky anymore after applying this
patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . The tests are not flaky anymore after applying
this patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[yabinh, 2016-08-02 09:09:42]

Description was changed from

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . The tests are not flaky anymore after applying
this patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example. The failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . The tests are not flaky anymore after applying
this patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example: the failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

[no sievers, 2016-08-02 19:50:31]

lgtm

[yabinh, 2016-08-05 07:26:22]

Description was changed from

==========
Fix flaky setUp() in tests related to ContentShellTestBase.

setUp() was flaky because we were reaching the element before it’s ready.
To make sure it's ready, we should wait until the page stopped
loading and shell’s view is ready to draw contents to the screen.

assertWaitForPageScaleFactorMatch() used to be a workaround for
crbug.com/179511 . The tests are not flaky anymore after applying
this patch. Thus, we can remove it.

This issue is a following issue of
https://codereview.chromium.org/2085813003/.
The above CL is not a real fix. It only reduces the failure rate.
Take ImeTest as an example: the failure was 3/20000 on Nexus 5,
and 21/1100 on Nexus 9.
After applying this patch, the failure rate is 0/6000+ (ImeTest)
and 0/10000 (other tests in total) on Nexus 9.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided  if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading. 

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 and 2 are doing this way. But it is not as good
as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[yabinh, 2016-08-05 07:27:46]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided  if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading. 

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 and 2 are doing this way. But it is not as good
as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 and 2 are doing this way. But it is not as
good as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[yabinh, 2016-08-05 07:29:49]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 07:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-08-05 07:35:17]

changwan@ asked if we could load the page only once. If so, we can use
|!isLoading()| to decide the target page has been loaded. Patch set 3 shows that
it's possible.

changewan@, PTAL.

[yabinh, 2016-08-05 07:38:08]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 and 2 are doing this way. But it is not as
good as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 is doing this way. But it is not as
good as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[yabinh, 2016-08-05 07:38:36]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 is doing this way. But it is not as
good as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 is doing this way. But it is not as good
as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[commit-bot: I haz the power, 2016-08-05 08:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:16:13]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2016-08-08 02:47:17]

lgtm w/ nits.

please do not talk about patchset1 in commit message.

Thanks, IMO this is better than the previous approach.

[yabinh, 2016-08-08 02:54:54]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

Of course, we can keep the second loading, and wait until the target
page is loaded. Patch set 1 is doing this way. But it is not as good
as loading only once.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[yabinh, 2016-08-08 02:56:16]

On 2016/08/08 02:47:17, Changwan Ryu wrote:
> lgtm w/ nits.
> 
> please do not talk about patchset1 in commit message.
> 
> Thanks, IMO this is better than the previous approach.

Done.

sievers@, can you take another look at this patch?

[no sievers, 2016-08-08 18:14:52]

On 2016/08/08 02:56:16, yabinh wrote:
> On 2016/08/08 02:47:17, Changwan Ryu wrote:
> > lgtm w/ nits.
> > 
> > please do not talk about patchset1 in commit message.
> > 
> > Thanks, IMO this is better than the previous approach.
> 
> Done.
> 
> sievers@, can you take another look at this patch?

lgtm

[yabinh, 2016-08-09 00:59:54]

The CQ bit was checked by yabinh@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 02:13:27]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

[commit-bot: I haz the power, 2016-08-09 02:13:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 02:15:22]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the 
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511

Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
Cr-Commit-Position: refs/heads/master@{#410519}
==========

[commit-bot: I haz the power, 2016-08-09 02:15:23]

Patchset 2 (id:??) landed as
https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
Cr-Commit-Position: refs/heads/master@{#410519}

[jbudorick, 2016-08-09 15:28:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2231433002/ by jbudorick@chromium.org.

The reason for reverting is: ContentViewZoomingTest.testJoystickZoomOut is now
very flaky in almost all configurations, including on the main waterfall.
crbug.com/635940.

[aelias_OOO_until_Jul13, 2016-08-09 23:02:48]

Reopening this issue.  I suggest bringing back the assertWaitForPatchScaleFactor
match check in ContentViewZoomingTest (it seems to be the only test negatively
affected) for now, and just reland using existing lgt'm (no need to create a new
codereview issue, you can just upload a new patchset to this one).

[yabinh, 2016-08-11 01:19:48]

The CQ bit was checked by yabinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 01:20:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yabinh, 2016-08-11 01:34:50]

I checked. Only ContentViewZoomingTest#testJoystickZoomOut is flaky. I'll bring
it back as aelias@ suggested.

[yabinh, 2016-08-11 01:35:08]

The CQ bit was unchecked by yabinh@chromium.org

[yabinh, 2016-08-11 01:35:17]

The CQ bit was checked by yabinh@chromium.org

[yabinh, 2016-08-11 01:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
changwan@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2199223002/#ps40001
(title: "Bringing back the assertWaitForPatchScaleFactorMatch check in
ContentViewZoomingTest")

[commit-bot: I haz the power, 2016-08-11 01:36:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:29:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 03:31:58]

Description was changed from

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511

Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
Cr-Commit-Position: refs/heads/master@{#410519}
==========

to

==========
Remove unnecessary page loading in ContentShellActivity

In ContentShellActivity#onCreate, we load the page twice: one is the
default page and the other is the target page.  The second loading can
be avoided if we load the target page in the first loading. Thus, we can
be sure that the target page will be ready once the page stops loading.

assertWaitForPageScaleFactorMatch() used to be a workaround for the
flaky bug crbug.com/179511 . The tests are not flaky anymore after
applying this patch. Thus, we can remove it.

BUG=580419,179511

Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
Committed: https://crrev.com/6554045543b20db3e810925f3cda0f0d93e4bae6
Cr-Original-Commit-Position: refs/heads/master@{#410519}
Cr-Commit-Position: refs/heads/master@{#411250}
==========

[commit-bot: I haz the power, 2016-08-11 03:31:59]

Patchset 3 (id:??) landed as
https://crrev.com/6554045543b20db3e810925f3cda0f0d93e4bae6
Cr-Commit-Position: refs/heads/master@{#411250}