content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java - Issue 2199223002: Remove unnecessary page loading in ContentShellActivity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

Issue 2199223002: Remove unnecessary page loading in ContentShellActivity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bringing back the assertWaitForPatchScaleFactorMatch check in ContentViewZoomingTest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

index 2c57e8143aa8a361c1c0a68db5477d0a00628c27..6d9e807901fba011bc56f0fc9ecdc2a6317db424 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java

@@ -18,7 +18,6 @@ public class ClickListenerTest extends ContentDetectionTestBase {

public void testClickContentOnLink() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/click_listeners.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// Clicks on addresses in links should change the url.

scrollAndTapNavigatingOut("linktest");

@@ -30,7 +29,6 @@ public class ClickListenerTest extends ContentDetectionTestBase {

public void testClickContentOnJSListener1() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/click_listeners.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// Clicks on addresses in elements listening to click events should be

// processed normally without address detection.

@@ -43,7 +41,6 @@ public class ClickListenerTest extends ContentDetectionTestBase {

public void testClickContentOnJSListener2() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/click_listeners.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// Same as previous test, but using addEventListener instead of onclick.

scrollAndTapNavigatingOut("clicktest2");