content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java - Issue 2199223002: Remove unnecessary page loading in ContentShellActivity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java

Issue 2199223002: Remove unnecessary page loading in ContentShellActivity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bringing back the assertWaitForPatchScaleFactorMatch check in ContentViewZoomingTest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java

index 899dda3c2474a301bff489aa1836abf83064785c..af1502647921eaa8476d4fe14258563d98269480 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java

@@ -30,7 +30,6 @@ public class PhoneNumberDetectionTest extends ContentDetectionTestBase {

public void testInternationalNumberIntents() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/phone_international.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// US: +1 650-253-0000.

String intentUrl = scrollAndTapExpectingIntent("US");

@@ -147,7 +146,6 @@ public class PhoneNumberDetectionTest extends ContentDetectionTestBase {

public void testLocalUSNumbers() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/phone_local.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// US_1: 1-888-433-5788.

String intentUrl = scrollAndTapExpectingIntent("US_1");

@@ -172,7 +170,6 @@ public class PhoneNumberDetectionTest extends ContentDetectionTestBase {

public void testLocalUKNumbers() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/phone_local.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// GB_1: (0) 20 7323 8299.

String intentUrl = scrollAndTapExpectingIntent("GB_1");

@@ -197,7 +194,6 @@ public class PhoneNumberDetectionTest extends ContentDetectionTestBase {

public void testLocalFRNumbers() throws Throwable {

startActivityWithTestUrl(

"content/test/data/android/content_detection/phone_local.html");

- assertWaitForPageScaleFactorMatch(1.0f);

// FR_1: 01 40 20 50 50.

String intentUrl = scrollAndTapExpectingIntent("FR_1");