Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2199203002: Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges This patch removes grammar checking code from the above named function of SpellChecker. It also simplifies its signature and stops its call sites from passing arguments only for grammar checking to it. BUG=619452 TESt=n/a; no visible change Committed: https://crrev.com/91ca178d41af494fd444fad6a44202d1d31388c6 Cr-Commit-Position: refs/heads/master@{#409149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -30 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 5 chunks +7 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-02 03:04:29 UTC) #4
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-02 07:06:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199203002/1
4 years, 4 months ago (2016-08-02 07:06:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 07:10:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 07:12:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ca178d41af494fd444fad6a44202d1d31388c6
Cr-Commit-Position: refs/heads/master@{#409149}

Powered by Google App Engine
This is Rietveld 408576698