Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2204843002: Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@PurgeMarkAllInRanges2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar This patch removes grammar checking from the above named function, and also stops its call sites from passing grammar checking related parameters to it. This patch also removes function SpellChecker::resolveTextCheckTypeMask() because it is not used any more. BUG=619452 TESt=n/a; no visible change Committed: https://crrev.com/7095e1641402c57f32d2cc952b4357af13ff8dfc Cr-Commit-Position: refs/heads/master@{#409156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 5 chunks +5 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-02 07:28:50 UTC) #6
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-02 07:37:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204843002/1
4 years, 4 months ago (2016-08-02 08:18:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 08:21:46 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 08:23:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7095e1641402c57f32d2cc952b4357af13ff8dfc
Cr-Commit-Position: refs/heads/master@{#409156}

Powered by Google App Engine
This is Rietveld 408576698