Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

This patch removes grammar checking code from the above named private member
function of SpellChecker, and make it absorbed by the public function of the
same name since the extra parameters are no longer effective.

BUG=619452
TESt=n/a; no visible change

Committed: https://crrev.com/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9
Cr-Commit-Position: refs/heads/master@{#409154}

[Xiaocheng, 2016-08-02 06:51:01]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 06:51:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-02 06:53:53]

Description was changed from

==========
Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

BUG=
==========

to

==========
Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

This patch removes grammar checking code from the above named private member
function of SpellChecker, and make it absorbed by the public function of the
same name since the extra parameters are no longer effective.

BUG=619452
TESt=n/a; no visible change
==========

[Xiaocheng, 2016-08-02 07:32:02]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-02 07:32:02]

PTAL.

[yosin_UTC9, 2016-08-02 07:38:15]

lgtm

https://codereview.chromium.org/2198223003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2198223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:344: //
markMisspellingsAndBadGrammar() is triggered by selection change, in which case
we check spelling, but don't autocorrect misspellings.
OPTIONAL: Could you format comments in 80 chars per line?

[Xiaocheng, 2016-08-02 07:40:01]

https://codereview.chromium.org/2198223003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2198223003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:344: //
markMisspellingsAndBadGrammar() is triggered by selection change, in which case
we check spelling, but don't autocorrect misspellings.
On 2016/08/02 at 07:38:15, Yosi_UTC9 wrote:
> OPTIONAL: Could you format comments in 80 chars per line?

All right. I'll do it in the next patch.

[commit-bot: I haz the power, 2016-08-02 07:55:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 07:55:02]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-02 07:58:33]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-02 07:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 08:02:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-02 08:03:45]

Description was changed from

==========
Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

This patch removes grammar checking code from the above named private member
function of SpellChecker, and make it absorbed by the public function of the
same name since the extra parameters are no longer effective.

BUG=619452
TESt=n/a; no visible change
==========

to

==========
Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

This patch removes grammar checking code from the above named private member
function of SpellChecker, and make it absorbed by the public function of the
same name since the extra parameters are no longer effective.

BUG=619452
TESt=n/a; no visible change

Committed: https://crrev.com/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9
Cr-Commit-Position: refs/heads/master@{#409154}
==========

[commit-bot: I haz the power, 2016-08-02 08:03:46]

Patchset 1 (id:??) landed as
https://crrev.com/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9
Cr-Commit-Position: refs/heads/master@{#409154}