DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message i…

DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message instead.

BUG=629307
Committed: https://crrev.com/ada1f290086ca075071746783931ddbe3b653d5f
Cr-Commit-Position: refs/heads/master@{#408836}

[pfeldman, 2016-07-29 18:07:53]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-07-29 18:37:44]

code lgtm, but we have to update histograms

https://codereview.chromium.org/2198503002/diff/20001/content/browser/bad_mes...
File content/browser/bad_message.h (right):

https://codereview.chromium.org/2198503002/diff/20001/content/browser/bad_mes...
content/browser/bad_message.h:162: // "python
tools/metrics/histograms/update_bad_message_reasons.py"
Did you run this script?

[pfeldman, 2016-07-29 22:22:42]

Description was changed from

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307
==========

to

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307
==========

[pfeldman, 2016-07-29 22:22:42]

pfeldman@chromium.org changed reviewers:
+ isherman@chromium.org

[pfeldman, 2016-07-29 22:22:48]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[pfeldman, 2016-07-29 22:23:09]

@isherman: could you stamp histograms please?

[commit-bot: I haz the power, 2016-07-29 22:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 22:26:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 22:26:26]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ilya Sherman, 2016-07-29 22:31:28]

histograms.xml lgtm

[pfeldman, 2016-07-30 00:21:29]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-07-30 00:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2198503002/#ps50001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-07-30 00:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:39:22]

Description was changed from

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307
==========

to

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307
==========

[commit-bot: I haz the power, 2016-07-30 01:39:23]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-07-30 01:41:38]

Description was changed from

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307
==========

to

==========
DevTools: do not CHECK devtools messages received from renderer in the browser,
issue bad_message instead.

BUG=629307

Committed: https://crrev.com/ada1f290086ca075071746783931ddbe3b653d5f
Cr-Commit-Position: refs/heads/master@{#408836}
==========

[commit-bot: I haz the power, 2016-07-30 01:41:40]

Patchset 4 (id:??) landed as
https://crrev.com/ada1f290086ca075071746783931ddbe3b653d5f
Cr-Commit-Position: refs/heads/master@{#408836}