Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Side by Side Diff: content/browser/bad_message.h

Issue 2198503002: DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message i… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_ 5 #ifndef CONTENT_BROWSER_BAD_MESSAGE_H_
6 #define CONTENT_BROWSER_BAD_MESSAGE_H_ 6 #define CONTENT_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserMessageFilter; 9 class BrowserMessageFilter;
10 class RenderProcessHost; 10 class RenderProcessHost;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 NI_IN_PAGE_NAVIGATION = 122, 147 NI_IN_PAGE_NAVIGATION = 122,
148 RPH_MOJO_PROCESS_ERROR = 123, 148 RPH_MOJO_PROCESS_ERROR = 123,
149 DBMF_INVALID_ORIGIN_ON_GET_SPACE = 124, 149 DBMF_INVALID_ORIGIN_ON_GET_SPACE = 124,
150 DBMF_INVALID_ORIGIN_ON_MODIFIED = 125, 150 DBMF_INVALID_ORIGIN_ON_MODIFIED = 125,
151 DBMF_INVALID_ORIGIN_ON_CLOSED = 126, 151 DBMF_INVALID_ORIGIN_ON_CLOSED = 126,
152 WSH_INVALID_HEADER_VALUE = 127, 152 WSH_INVALID_HEADER_VALUE = 127,
153 SWDH_SET_HOSTED_VERSION_INVALID_HOST = 128, 153 SWDH_SET_HOSTED_VERSION_INVALID_HOST = 128,
154 SWDH_SET_HOSTED_VERSION_PROCESS_MISMATCH = 129, 154 SWDH_SET_HOSTED_VERSION_PROCESS_MISMATCH = 129,
155 MSDH_INVALID_FRAME_ID = 130, 155 MSDH_INVALID_FRAME_ID = 130,
156 SDH_INVALID_PORT_RANGE = 131, 156 SDH_INVALID_PORT_RANGE = 131,
157 RFH_INCONSISTENT_DEVTOOLS_MESSAGE = 132,
157 158
158 // Please add new elements here. The naming convention is abbreviated class 159 // Please add new elements here. The naming convention is abbreviated class
159 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the 160 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the
160 // reason. After making changes, you MUST update histograms.xml by running: 161 // reason. After making changes, you MUST update histograms.xml by running:
161 // "python tools/metrics/histograms/update_bad_message_reasons.py" 162 // "python tools/metrics/histograms/update_bad_message_reasons.py"
dgozman 2016/07/29 18:37:43 Did you run this script?
162 BAD_MESSAGE_MAX 163 BAD_MESSAGE_MAX
163 }; 164 };
164 165
165 // Called when the browser receives a bad IPC message from a renderer process on 166 // Called when the browser receives a bad IPC message from a renderer process on
166 // the UI thread. Logs the event, records a histogram metric for the |reason|, 167 // the UI thread. Logs the event, records a histogram metric for the |reason|,
167 // and terminates the process for |host|. 168 // and terminates the process for |host|.
168 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason); 169 void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason);
169 170
170 // Called when a browser message filter receives a bad IPC message from a 171 // Called when a browser message filter receives a bad IPC message from a
171 // renderer or other child process. Logs the event, records a histogram metric 172 // renderer or other child process. Logs the event, records a histogram metric
172 // for the |reason|, and terminates the process for |filter|. 173 // for the |reason|, and terminates the process for |filter|.
173 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason); 174 void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason);
174 175
175 } // namespace bad_message 176 } // namespace bad_message
176 } // namespace content 177 } // namespace content
177 178
178 #endif // CONTENT_BROWSER_BAD_MESSAGE_H_ 179 #endif // CONTENT_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698