DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message i…

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include <map>
 #include <vector>
 
 #include "base/guid.h"
@@ skipping 269 matching lines @@
 DevToolsMessageChunkProcessor::DevToolsMessageChunkProcessor(
     const SendMessageCallback& callback)
     : callback_(callback),
       message_buffer_size_(0),
       last_call_id_(0) {
 }
 
 DevToolsMessageChunkProcessor::~DevToolsMessageChunkProcessor() {
 }
 
-void DevToolsMessageChunkProcessor::ProcessChunkedMessageFromAgent(
+bool DevToolsMessageChunkProcessor::ProcessChunkedMessageFromAgent(
     const DevToolsMessageChunk& chunk) {
   if (chunk.is_last && !chunk.post_state.empty())
     state_cookie_ = chunk.post_state;
   if (chunk.is_last)
     last_call_id_ = chunk.call_id;
 
   if (chunk.is_first && chunk.is_last) {
-    CHECK(message_buffer_size_ == 0);
+    if (message_buffer_size_ != 0)
+      return false;
     callback_.Run(chunk.session_id, chunk.data);
-    return;
+    return true;
   }
 
   if (chunk.is_first) {
     message_buffer_ = std::string();
     message_buffer_.reserve(chunk.message_size);
     message_buffer_size_ = chunk.message_size;
   }
 
-  CHECK(message_buffer_.size() + chunk.data.size() <=
-      message_buffer_size_);
+  if (message_buffer_.size() + chunk.data.size() > message_buffer_size_)
+    return false;
   message_buffer_.append(chunk.data);
 
   if (chunk.is_last) {
-    CHECK(message_buffer_.size() == message_buffer_size_);
+    if (message_buffer_.size() != message_buffer_size_)
+      return false;
     callback_.Run(chunk.session_id, message_buffer_);
     message_buffer_ = std::string();
     message_buffer_size_ = 0;
   }
+  return true;
 }
 
 }  // namespace content