Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Issue 2198433003: Remove some ancillary users of SkSurface::MakeRenderTargetDirect (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove some ancillary users of SkSurface::MakeRenderTargetDirect calved off of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198433003 Committed: https://skia.googlesource.com/skia/+/12e9662cf796c7c1bd1f6e247691d8603335e57f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M debugger/QT/SkGLWidget.h View 1 chunk +4 lines, -2 lines 0 comments Download
M debugger/QT/SkGLWidget.cpp View 3 chunks +7 lines, -12 lines 0 comments Download
M example/SkiaSDLExample.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M experimental/SkV8Example/SkV8Example.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M include/core/SkSurface.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 4 months ago (2016-07-29 17:42:22 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-07-29 17:56:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198433003/1
4 years, 4 months ago (2016-08-01 12:32:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 12:53:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12e9662cf796c7c1bd1f6e247691d8603335e57f

Powered by Google App Engine
This is Rietveld 408576698