Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2197953002: Remove unnecessary uses of HTMLDocument (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, Rik, chasej+watch_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, gavinp+loader_chromium.org, haraken, Nate Chapin, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, loading-reviews+parser_chromium.org, loading-reviews_chromium.org, nzolghadr+blinkwatch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, webcomponents-bugzilla_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary uses of HTMLDocument Most of HTMLDocument has already been merged into Document, so these code paths no longer anything HTMLDocument-specific. Drive-by: Remove some unnecessary includes and fix typo in HTMLDocument.cpp BUG=238368 Committed: https://crrev.com/3dda93ba7fa7ae42912dbdeae479b785eac0fe9a Cr-Commit-Position: refs/heads/master@{#409188}

Patch Set 1 #

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -92 lines) Patch
M third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/DragUpdateTest.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStackTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 1 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp View 6 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
foolip
PTAL
4 years, 4 months ago (2016-08-01 13:51:20 UTC) #7
foolip
Renewed activity on https://github.com/whatwg/dom/issues/221 is what prompted me to look into how HTMLDocument is used, ...
4 years, 4 months ago (2016-08-01 13:52:28 UTC) #8
tkent
lgtm
4 years, 4 months ago (2016-08-01 22:46:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197953002/20001
4 years, 4 months ago (2016-08-02 12:27:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 14:36:00 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:38:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dda93ba7fa7ae42912dbdeae479b785eac0fe9a
Cr-Commit-Position: refs/heads/master@{#409188}

Powered by Google App Engine
This is Rietveld 408576698