third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp - Issue 2197953002: Remove unnecessary uses of HTMLDocument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

Issue 2197953002: Remove unnecessary uses of HTMLDocument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

index f2d8fbe08a9ed99cf919b9e72944b9fbb265abce..0eca206a23db2b7e38cdf96d5fb4e4c5937dff5d 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

@@ -6,11 +6,11 @@

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ExceptionStatePlaceholder.h"

+#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

#include "core/dom/URLSearchParams.h"

#include "core/frame/FrameView.h"

#include "core/html/FormData.h"

-#include "core/html/HTMLDocument.h"

#include "core/html/HTMLFormElement.h"

#include "core/html/forms/FormController.h"

#include "core/testing/DummyPageHolder.h"

@@ -25,10 +25,10 @@ protected:

void SetUp() override

{

m_dummyPageHolder = DummyPageHolder::create();

- m_document = toHTMLDocument(&m_dummyPageHolder->document());

+ m_document = &m_dummyPageHolder->document();

}

- HTMLDocument& document() const { return *m_document; }

+ Document& document() const { return *m_document; }

HTMLFormElement* populateForm(const char* enctype, const char* html)

{

@@ -47,7 +47,7 @@ protected:

private:

std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

- Persistent<HTMLDocument> m_document;

+ Persistent<Document> m_document;

};

TEST_F(PasswordCredentialTest, CreateFromMultipartForm)